Skip to content

feat: track PostgreSQL session identity across pooled connections - #1587

Open
murex971 wants to merge 14 commits into
mainfrom
session-role-cleanup
Open

feat: track PostgreSQL session identity across pooled connections#1587
murex971 wants to merge 14 commits into
mainfrom
session-role-cleanup

Conversation

@murex971

@murex971 murex971 commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prevent SET ROLE and SET SESSION AUTHORIZATION state from leaking between
clients in transaction pooling.
Introduce dedicated session identity tracking for authorization and role.

closes: #1341

@codecov

codecov Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.67093% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/net/parameter.rs 93.33% 23 Missing ⚠️
.../src/frontend/router/parser/query/test/test_set.rs 94.33% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

levkk
levkk reviewed Sep 18, 2026
View reviewed changes
Comment thread pgdog/src/backend/pool/guard.rs
@murex971
murex971 requested a review from levkk September 21, 2026 13:53
levkk
levkk reviewed Sep 21, 2026
View reviewed changes
Comment thread pgdog/src/frontend/client/query_engine/set.rs Outdated
@murex971
murex971 requested a review from levkk September 22, 2026 13:47
@murex971 murex971 changed the title reset session identity during pool cleanup feat: track PostgreSQL session identity across pooled connections Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levkk levkk Awaiting requested review from levkk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Transaction pooling leaks SET ROLE between connections

2 participants

@murex971 @levkk